Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height Missing in Some x/distribution Routes #5504

Closed
1 of 4 tasks
alexanderbez opened this issue Jan 10, 2020 · 0 comments · Fixed by #5508
Closed
1 of 4 tasks

Height Missing in Some x/distribution Routes #5504

alexanderbez opened this issue Jan 10, 2020 · 0 comments · Fixed by #5508
Labels
C:x/distribution distribution module related T:Bug

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Jan 10, 2020

Summary of Bug

Not all x/distribution REST handlers include/inject the height of the query:

  • /distribution/parameters
  • /distribution/validators/{validatorAddr}/rewards
  • /distribution/validators/{validatorAddr}
  • /distribution/delegators/{delegatorAddr}/rewards/{validatorAddr}
  • /distribution/delegators/{delegatorAddr}/rewards

The handlers need to have the height added:

cliCtx = cliCtx.WithHeight(height)
rest.PostProcessResponse(w, cliCtx, res)

Version

6024115


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/distribution distribution module related T:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant