Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLIContext // Codec #4479

Closed
4 tasks
alexanderbez opened this issue Jun 4, 2019 · 3 comments · Fixed by #4499
Closed
4 tasks

CLIContext // Codec #4479

alexanderbez opened this issue Jun 4, 2019 · 3 comments · Fixed by #4499
Labels
good first issue Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Milestone
v1.0 LTS

Comments

@alexanderbez
Copy link
Contributor

Summary

Many places in client-land we pass a CLIContext object and a codec to respective handlers, methods, and functions. This is completely unnecessary afaik due to the CLIContext already having the codec set. A lot of interface/function/method signatures can be cleaned up by removing the need for a codec as an argument.

/cc @rigelrozanski @jackzampolin @fedekunze

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez alexanderbez added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. good first issue labels Jun 4, 2019
@alexanderbez alexanderbez mentioned this issue Jun 4, 2019
Merged
5 tasks
@jackzampolin
Copy link
Member

I think there is already a codec on the cliCtx.

@alexanderbez
Copy link
Contributor Author

@jackzampolin correct, hence my statement: This is completely unnecessary afaik due to the CLIContext already having the codec set. 👍

@rigelrozanski rigelrozanski added this to the v1.0 LTS milestone Jun 5, 2019
@rigelrozanski
Copy link
Contributor

Oh dang didn't realize this was in here. nice yeah let's add this to the 1.0 refactors

@alexanderbez alexanderbez mentioned this issue Jun 6, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
v1.0 LTS
Development

Successfully merging a pull request may close this issue.

Remove Client Codec Redundancy cosmos/cosmos-sdk
3 participants
@alexanderbez @jackzampolin @rigelrozanski