Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stages/disks: support resizing an existing partition #1087

Merged
merged 4 commits into from
Sep 16, 2020
Merged

stages/disks: support resizing an existing partition #1087

merged 4 commits into from
Sep 16, 2020

Conversation

sohankunkerkar
Copy link
Member

Fixes #924

@sohankunkerkar sohankunkerkar force-pushed the resize-partition branch 7 times, most recently from b5823e7 to 808c76d Compare September 9, 2020 03:14
@sohankunkerkar sohankunkerkar marked this pull request as ready for review September 9, 2020 14:28
@sohankunkerkar sohankunkerkar changed the title WIP stages/disks: Fix to resize an existing partition stages/disks: Fix to resize an existing partition Sep 9, 2020
arithx
arithx reviewed Sep 10, 2020
View reviewed changes
config/v3_2_experimental/types/schema.go Outdated Show resolved Hide resolved
internal/sgdisk/sgdisk.go Outdated Show resolved Hide resolved
bgilbert
bgilbert reviewed Sep 10, 2020
View reviewed changes
config/v3_2_experimental/translate/translate.go Show resolved Hide resolved
internal/exec/stages/disks/partitions.go Outdated Show resolved Hide resolved
internal/exec/stages/disks/partitions.go Outdated Show resolved Hide resolved
internal/sgdisk/sgdisk.go Outdated Show resolved Hide resolved
internal/sgdisk/sgdisk.go Outdated Show resolved Hide resolved
doc/configuration-v3_2_experimental.md Outdated Show resolved Hide resolved
tests/positive/partitions/creation-mb.go Outdated Show resolved Hide resolved
tests/positive/partitions/creation-mb.go Show resolved Hide resolved
@sohankunkerkar sohankunkerkar force-pushed the resize-partition branch 6 times, most recently from 9c6bb56 to d06998d Compare September 11, 2020 01:25
@bgilbert bgilbert changed the title stages/disks: Fix to resize an existing partition stages/disks: support resizing an existing partition Sep 11, 2020
bgilbert
bgilbert reviewed Sep 11, 2020
View reviewed changes
internal/exec/stages/disks/partitions.go Outdated Show resolved Hide resolved
internal/exec/stages/disks/partitions.go Outdated Show resolved Hide resolved
doc/operator-notes.md Outdated Show resolved Hide resolved
@bgilbert bgilbert mentioned this pull request Sep 11, 2020
Open
@sohankunkerkar sohankunkerkar force-pushed the resize-partition branch 7 times, most recently from 25490fc to 97ce6a8 Compare September 14, 2020 20:24
@sohankunkerkar
Copy link
Member Author

CI is failing due to coreos/fedora-coreos-tracker#619

arithx
arithx reviewed Sep 15, 2020
View reviewed changes
internal/exec/stages/disks/partitions.go Outdated Show resolved Hide resolved
doc/operator-notes.md Outdated Show resolved Hide resolved
bgilbert
bgilbert reviewed Sep 15, 2020
View reviewed changes
internal/exec/stages/disks/partitions.go Outdated Show resolved Hide resolved
internal/exec/stages/disks/partitions.go Outdated Show resolved Hide resolved
doc/operator-notes.md Outdated Show resolved Hide resolved
@sohankunkerkar sohankunkerkar force-pushed the resize-partition branch 3 times, most recently from 91919b0 to 3d40179 Compare September 15, 2020 13:22
@sohankunkerkar
config: add resize to schema
5267c6e 
This field is added to resize an existing partition
@sohankunkerkar
stages/disks: support resizing an existing partition
01e1eaa 
Fixes coreos#924
This fix will allow users to resize an existing partition without wiping
out an entry from the partition table.
@sohankunkerkar
docs/*: add resize partition info
ed48618
@sohankunkerkar
tests/*: add test for resizing an existing partition
aeaae9a
@jlebon
Copy link
Member

jlebon commented Sep 15, 2020

This will need #1093 to unblock CI.

arithx
arithx approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@arithx arithx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM

@sohankunkerkar sohankunkerkar merged commit 4d7f5fb into coreos:master Sep 16, 2020
@sohankunkerkar sohankunkerkar deleted the resize-partition branch September 16, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgilbert bgilbert bgilbert approved these changes

@arithx arithx arithx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to resize an existing partition
4 participants
@sohankunkerkar @jlebon @bgilbert @arithx