Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fedora-coreos-pinger #770

Closed
bgilbert opened this issue Mar 18, 2021 · 12 comments · Fixed by coreos/fedora-coreos-config#1811
Closed

Remove fedora-coreos-pinger #770

bgilbert opened this issue Mar 18, 2021 · 12 comments · Fixed by coreos/fedora-coreos-config#1811
Assignees
@bgilbert
Labels
kind/enhancement status/decided

Comments

@bgilbert
Copy link
Contributor

fedora-coreos-pinger was intended to serve two purposes. In the medium term, it was intended to provide a mechanism for collecting anonymized aggregate statistics about the Fedora CoreOS installed base. In the short term, the plan was to ship only the parser for the config file. That way we could ship configuration docs alongside the first release of FCOS, allowing users to opt out of statistics gathering on day 1 and avoid surprises when the rest of the statistics system eventually shipped.

We did ship the config parser, but we've never implemented the rest of the statistics system and it hasn't been a priority to do so. Also, the only place we ever documented pinger configuration in FCOS is in the CL migration notes.

We're currently planning to do some basic population counting via #717, which addresses part of the problem pinger was meant to solve. If we want to gather additional statistics down the road, we'll need to provide a lot of advance notice, since most users probably aren't aware of pinger's opt-out mechanism. Given that, it doesn't seem important to continue shipping a tool for validating an unused config file.

Consider removing fedora-coreos-pinger from the distro. We can always add it back later if we end up needing it.
@bgilbert bgilbert mentioned this issue Mar 18, 2021
Open
@ashcrow
Copy link
Member

ashcrow commented Mar 18, 2021

If "count me" fills the same requirements the team and community were hoping for then 👍

@bgilbert
Copy link
Contributor Author

Most of the info we were hoping to get from pinger will not be collected by countme.

@jlebon jlebon mentioned this issue Jul 7, 2021
Merged
@bgilbert bgilbert added the meeting topics for meetings label Jun 17, 2022
@bgilbert
Copy link
Contributor Author

Added meeting label.

@travier
Copy link
Member

travier commented Jun 22, 2022

We've discussed this topic in today's FCOS community meeting:

We will remove fedora-coreos-pinger from FCOS and archive the repo upstream.
We still believe this functionality would be useful and are open to re-adding
the package if the functionality is built out.

@travier travier added status/decided status/pending-action Needs action and removed meeting topics for meetings labels Jun 22, 2022
@bgilbert bgilbert self-assigned this Jun 22, 2022
@bgilbert
Copy link
Contributor Author

bgilbert commented Jun 22, 2022 •
edited
Loading

To do:

This was referenced Jun 22, 2022
Merged
Merged
@bgilbert bgilbert changed the title Consider removing fedora-coreos-pinger Remove fedora-coreos-pinger Jun 22, 2022
@bgilbert bgilbert mentioned this issue Jun 22, 2022
Open
@jlebon
Copy link
Member

jlebon commented Jun 22, 2022

To do:

There are a few hits in cosa as well we'll want to rip out.

bgilbert added a commit to coreos/fedora-coreos-config that referenced this issue Jun 22, 2022
@bgilbert
Drop fedora-coreos-pinger
0b03cef 
It's a stub service that only parses a config file, and we never
adequately documented the config file.  We have no current plans to
finish implementing the service, so let's drop it.

Fixes coreos/fedora-coreos-tracker#770.
@bgilbert bgilbert reopened this Jun 22, 2022
bgilbert added a commit to coreos/fedora-coreos-docs that referenced this issue Jun 22, 2022
@bgilbert
migrate-cl: drop fedora-coreos-pinger
3578ff1 
It's being removed from the distro:

    coreos/fedora-coreos-tracker#770

Link to the counting docs instead.
@bgilbert
Copy link
Contributor Author

There are a few hits in cosa as well we'll want to rip out.

Good catch!

@dustymabe dustymabe added the status/pending-testing-release Fixed upstream. Waiting on a testing release. label Jun 22, 2022
@bgilbert bgilbert mentioned this issue Jun 22, 2022
Merged
@bgilbert bgilbert added status/pending-next-release Fixed upstream. Waiting on a next release. and removed status/pending-action Needs action labels Jun 23, 2022
@bgilbert
Copy link
Contributor Author

Done!

jlebon added a commit to jlebon/ostree that referenced this issue Jun 23, 2022
@jlebon
tests/inst/destructive: stop disabling fedora-coreos-pinger
7814d93 
It was removed from FCOS:
coreos/fedora-coreos-tracker#770
@jlebon jlebon mentioned this issue Jun 23, 2022
Merged
@jlebon
Copy link
Member

jlebon commented Jun 23, 2022

Also ostreedev/ostree#2658.

@dustymabe
Copy link
Member

The fix for this went into next stream release 36.20220703.1.1. Please try out the new release and report issues.

@dustymabe
Copy link
Member

The fix for this went into testing stream release 36.20220703.2.1. Please try out the new release and report issues.

@dustymabe dustymabe added status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. and removed status/pending-testing-release Fixed upstream. Waiting on a testing release. status/pending-next-release Fixed upstream. Waiting on a next release. labels Jul 7, 2022
@dustymabe
Copy link
Member

The fix for this went into stable stream release 36.20220703.3.1.

@dustymabe dustymabe removed the status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. label Jul 19, 2022
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@bgilbert @HuijingHei
Drop fedora-coreos-pinger
8824d66 
It's a stub service that only parses a config file, and we never
adequately documented the config file.  We have no current plans to
finish implementing the service, so let's drop it.

Fixes coreos/fedora-coreos-tracker#770.
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@bgilbert @HuijingHei
Drop fedora-coreos-pinger
87b83e2 
It's a stub service that only parses a config file, and we never
adequately documented the config file.  We have no current plans to
finish implementing the service, so let's drop it.

Fixes coreos/fedora-coreos-tracker#770.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgilbert bgilbert

Labels
kind/enhancement status/decided
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop fedora-coreos-pinger
5 participants
@ashcrow @bgilbert @dustymabe @jlebon @travier