Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: add LUKS docs #172

Merged
merged 1 commit into from
Oct 6, 2020
Merged

storage: add LUKS docs #172

merged 1 commit into from
Oct 6, 2020

Conversation

arithx
Copy link

@arithx arithx commented Sep 2, 2020

Adds two LUKS based examples, a data directory & the root filesystem.

@arithx
Copy link
Author

arithx commented Sep 2, 2020

Docs themselves are tested but this is blocked behind a new clevis release & fedora-coreos-config having the clevis* dependencies added.

travier
travier reviewed Sep 7, 2020
View reviewed changes
Copy link
Member

@travier travier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also I have not tested the examples.

modules/ROOT/pages/storage.adoc Show resolved Hide resolved
@arithx arithx marked this pull request as ready for review September 11, 2020 00:20
@arithx
Copy link
Author

arithx commented Sep 11, 2020

Marked as ready for review now that coreos/fedora-coreos-config#609 is up and approved (merge is waiting on additional debugging in coreos/fedora-coreos-tracker#619)

@arithx arithx mentioned this pull request Sep 11, 2020
Closed
jlebon
jlebon reviewed Sep 11, 2020
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Will look at refreshing #167 and getting that in next week so we can unblock this!

modules/ROOT/pages/storage.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/storage.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/storage.adoc Show resolved Hide resolved
@travier travier mentioned this pull request Sep 16, 2020
Merged
@jlebon jlebon added the hold label Sep 17, 2020
jlebon
jlebon approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I added a hold label for the same reason as #178.

I think you can rebase this on the latest master and just depend on #178 now that #167 has merged.

jlebon
jlebon approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just needs a rebase.

@arithx
storage: add LUKS docs
33cfe81 
Adds two LUKS based examples, a data directory & the root filesystem.
@arithx arithx merged commit 73e3a3a into coreos:master Oct 6, 2020
@bgilbert bgilbert mentioned this pull request Feb 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon approved these changes

@travier travier travier approved these changes

Assignees
No one assigned
Labels
hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arithx @jlebon @travier