Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated page to configuring storage #167

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Aug 27, 2020

Let's have a page where we list different ways one can modify the
default storage layout on FCOS. This will also include root
reprovisioning examples such as xfs → btrfs, or root on RAID1,
eventually root on LUKS, etc...

Closes: #131

@jlebon
Copy link
Member Author

jlebon commented Aug 27, 2020

Leaving as draft for now until coreos/fedora-coreos-config#503 is in a release and I actually double-check all the example configs.

Copy link

@arithx arithx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cgwalters
Copy link
Member

Looks sane so far. One thing we could do is drop things like this in a hackmd.io first and that way people can fix typos and such directly (though I didn't see any yet).

@jlebon
Copy link
Member Author

jlebon commented Sep 14, 2020

OK, I split out the root reprovisioning bits into #178 because it hasn't hit stable yet. The rest here we can merge now.

All tested working and ready to go!

(On that subject, we should hack up a script here which would kola test all the examples. Edit: filed #179)

Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment but otherwise LGTM. We need this as we have people asking about this on discourse.

modules/ROOT/pages/storage.adoc Show resolved Hide resolved
Let's have a page where we list different ways one can modify the
default storage layout on FCOS. This will also include root
reprovisioning examples such as xfs → btrfs, or root on RAID1,
eventually root on LUKS, etc...

Closes: coreos#131
@jlebon jlebon merged commit 1b8d5b3 into coreos:master Sep 16, 2020
@jlebon jlebon deleted the pr/add-storage branch September 16, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have dedicated page to document storage-related modifications
4 participants