coreos-growpart: drop support for growing multipathed disks #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The model we're moving towards is one where multipath enablement is configured via Ignition and so only takes effect on the next boot: openshift/os#484 (comment) Therefore, we don't need to worry here about support for growing a multipathed root partition. This simplifies a big chunk of the script.
That's the convention for systemd unit descriptions.
|
(Not tested, but pretty straightforward.) |
jlebon
commented
Jan 14, 2021
| @@ -45,43 +45,23 @@ case "${TYPE:-}" in | |||
| *) echo "error: Unsupported filesystem for ${path}: '${TYPE:-}'" 1>&2; exit 1 ;; | |||
| esac | |||
|
|
|||
| if [[ "${src}" =~ "/dev/mapper" ]]; then | |||
|
This should be an easy one to review! |
arithx
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The model we're moving towards is one where multipath enablement is
configured via Ignition and so only takes effect on the next boot:
openshift/os#484 (comment)
Therefore, we don't need to worry here about support for growing a
multipathed root partition. This simplifies a big chunk of the script.