base: Use /var/home for home directories by default #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came up in `#silverblue` discussion; let's do it here first under the general concept that most changes to the "core" underlying both Silverblue and FCOS should be made in FCOS first. Tested locally with a build+run. It doesn't affect the `core` user today, because anaconda+libuser aren't reading the defaults from the target OS.
|
LGTM |
|
Can you expand on this? Shouldn't it Just Work ™️ both ways (canonicalized or not)? |
|
Further discussion about this in https://discussion.fedoraproject.org/t/adapting-user-home-in-etc-passwd/487/6 |
I think this is basically about improving the UX in edge cases. Going to go ahead and merge since it is an improvement. |
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Jan 5, 2019
For a long time I've resisted encoding "policy" into rpm-ostree as much as possible. Doing so makes it more distribution specific for example. That said, for `/var/home` there argument for doing this in rpm-ostree is that we already make that symlink in our hardcoded rootfs. So we might as well do the other fixups for it. coreos/fedora-coreos-config#18 https://pagure.io/workstation-ostree-config/pull-request/121 https://discussion.fedoraproject.org/t/adapting-user-home-in-etc-passwd/487/6 justjanne/powerline-go#94
|
And after reflecting on this later on in the evening, I decided instead to do: Pushed a revert of this one to master. |
rh-atomic-bot
pushed a commit
to coreos/rpm-ostree
that referenced
this pull request
Jan 7, 2019
For a long time I've resisted encoding "policy" into rpm-ostree as much as possible. Doing so makes it more distribution specific for example. That said, for `/var/home` there argument for doing this in rpm-ostree is that we already make that symlink in our hardcoded rootfs. So we might as well do the other fixups for it. coreos/fedora-coreos-config#18 https://pagure.io/workstation-ostree-config/pull-request/121 https://discussion.fedoraproject.org/t/adapting-user-home-in-etc-passwd/487/6 justjanne/powerline-go#94 Closes: #1726 Approved by: jlebon
c4rt0
pushed a commit
to c4rt0/fedora-coreos-config
that referenced
this pull request
Mar 27, 2023
Makefile more
dustymabe
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in
#silverbluediscussion; let's do it herefirst under the general concept that most changes to the "core"
underlying both Silverblue and FCOS should be made in FCOS first.
Tested locally with a build+run. It doesn't affect the
coreuser today, because anaconda+libuser aren't reading the defaults
from the target OS.