interactive live ISO experience no longer works with Ignition 2.4.0 #514
Comments
|
cc @bgilbert. We should get this fixed before the testing release. |
|
One suggestion was to use the structured journal messages ignition logs now but that gets tricky because we're running in a generator. Obviously one solution may be to hoist this stuff into a different place so we don't have that limitation. |
|
Whoops, didn't catch that implication when writing the PR sorry. One alternative could be to temporarily have Ignition write out a separate file indicating that there was no user configuration. Or we could have a fetch-style stage that could exit depending on whether or not there is a provider / user config defined which we could call in the detection script. |
What's tricky about querying the journal from a generator? (The reason this works is because this generator is running in the real root, Ignition runs in the initrd, so it's not going to race or anything) |
|
Folded a fix for this into #426. |
We shouldn't use `/run/ignition.json` to determine whether a user config was provided since it's implementation details. Instead, use the new official journal messages that Ignition emits. Closes: coreos#514
|
One thing related to this is that we should fix (or check if it's already fixed by the recent work to close races) the |
We shouldn't use `/run/ignition.json` to determine whether a user config was provided since it's implementation details. Instead, use the new official journal messages that Ignition emits. Closes: coreos#514
Thanks @jlebon
I just wasn't sure if it would work or not, or cause other problems. Looks like it works 🎉 |
We shouldn't use `/run/ignition.json` to determine whether a user config was provided since it's implementation details. Instead, use the new official journal messages that Ignition emits. This is complicated by the fact that we need to support RHCOS, where the journal messages haven't been backported. Use the fact that we always have a base config to key off of whether to use the old behaviour vs the new one. (More accurately, we'd want to check for coreos/ignition#1002, but there's no easy way to do this from the outside. Alternatively we can check the Ignition version, though that's deeply nested under `/usr/lib/dracut/...`). Anyway, this should be temporary until RHCOS moves to spec v3. Closes: coreos#514
fedora-coreos-config: bump for in-place LUKS auto-growpart
In the new Ignition we now default to writing out a config even if once wasn't provided by the user (coreos/ignition#1002). This breaks our hacky detection of if an Ignition config was provided for the ISO boot and causes the "interactive Live ISO" experience to not happen. We need to come up with a new way for us to properly detect this so we can not have a regression.
The text was updated successfully, but these errors were encountered: