rdcore/rootmap: also inject rootflags karg #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to be able to do e.g. `runcmd!("foo")`. But the pattern we use
doesn't match because it doesn't have a comma after the first macro
argument. Add a pattern for this.
bgilbert
approved these changes
Aug 24, 2020
31 tasks
Because we now always inject a `root` karg, it means that it's systemd which does the mount. But then, systemd doesn't know to use the `prjquota` flag we want by default for xfs. Call out to a `coreos-rootflags` helper where the source of truth for default root mount flags lives and embed its output if any is provided.
bgilbert
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we now always inject a
rootkarg, it means that it's systemdwhich does the mount. But then, systemd doesn't know to use the
prjquotaflag we want by default for xfs.Call out to a
coreos-rootflagshelper where the source of truth fordefault root mount flags lives and embed its output if any is provided.