Drop references to fedora-coreos-pinger #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
Accidentally created as draft; ready for review. |
We already have an explicit check to ignore such accounts.
fedora-coreos-pinger is being removed from FCOS. Also it never did anything beyond parsing its config file.
|
I'm +1 on this but do we need to wait until pinger is no longer in the stable stream before we merge this? |
|
Nothing in this PR should cause a behavior change with OS images that still include the pinger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're removing it from FCOS (coreos/fedora-coreos-tracker#770).
Nothing in this PR should cause a behavior change with OS images that still include the pinger.