Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola: tweaks around handling of external tests #1591

Merged
merged 2 commits into from
Jul 15, 2020

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Jul 13, 2020

commit eca576068f79b8df16715f5651a0310b33b8cbe8
Date:   Mon Jul 13 16:24:49 2020 -0400

    kola: resolve directory when using `-E .`

    Otherwise the generated tests will have funny names like `ext...foobar`.

commit 0ab5a4a45898d2d34bceedba754d5dfde715e17f
Date:   Mon Jul 13 16:24:50 2020 -0400

    kola: add ext tests in current dir if no -E given

    E.g. when hacking on Ignition tests, I want to be able to just do
    `kola run --workdir /srv/fcos ext.ignition.foobar` from the Ignition git
    repo.

Found these useful when hacking on #1589 for tests for coreos/fedora-coreos-config#503.

Otherwise the generated tests will have funny names like `ext...foobar`.
E.g. when hacking on Ignition tests, I want to be able to just do
`kola run --workdir /srv/fcos ext.ignition.foobar` from the Ignition git
repo.
Copy link
Member

@sohankunkerkar sohankunkerkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miabbott
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, miabbott, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4d952b5 into coreos:master Jul 15, 2020
@jlebon jlebon deleted the pr/bump-ignition-exp-prep branch April 22, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants