Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psgo: handle ESRCH as ENOENT #155

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented May 7, 2024

for /proc/$PID/cmdline, the kernel could return ESRCH instead of ENOENT if the target process is terminated between the opening of the "cmdline" file and reading from it.

Handle ESRCH in the same way as ENOENT when reading from the proc file system.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

for /proc/$PID/cmdline, the kernel could return ESRCH instead of
ENOENT if the target process is terminated between the opening of the
"cmdline" file and reading from it.

Handle ESRCH in the same way as ENOENT when reading from the proc file
system.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
Copy link
Member Author

giuseppe commented May 7, 2024

@vrothberg @rhatdan PTAL

Copy link
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit 1ee6f99 into containers:main May 8, 2024
7 checks passed
@vrothberg
Copy link
Member

I don't see a new release of psgo. If this fixed containers/podman#22619, let's create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants