Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings tests: re-disable flaky pause|unpause test #8536

Closed
wants to merge 1 commit into from

Conversation

edsantiago
Copy link
Member

It's continuing to flake, and I see no activity on #6518.

Flakes are evil. Let's just disable the test again, until someone
takes the initiative to fix the bug.

Signed-off-by: Ed Santiago santiago@redhat.com

It's continuing to flake, and I see no activity on containers#6518.

Flakes are evil. Let's just disable the test again, until someone
takes the initiative to fix the bug.

Signed-off-by: Ed Santiago <santiago@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2020
@edsantiago edsantiago changed the title bindings tests: re-disable flaky pause|unpuause test bindings tests: re-disable flaky pause|unpause test Dec 1, 2020
@TomSweeneyRedHat
Copy link
Member

LGTM
after this goes through, can you add a reminder in the issue to remove the skip please (assuming you haven't already.)

@TomSweeneyRedHat
Copy link
Member

Forgot to add, happy green test buttons.

@edsantiago
Copy link
Member Author

/hold

@rhatdan has a possible fix, see conversation in #6518

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2020
@rhatdan
Copy link
Member

rhatdan commented Dec 1, 2020

#8541 should hopefully fix the race.

@rhatdan rhatdan closed this Dec 1, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants