Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitor for client closing stream #7986

Merged
merged 1 commit into from
Oct 10, 2020
Merged

Monitor for client closing stream #7986

merged 1 commit into from
Oct 10, 2020

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Oct 9, 2020 •
edited
Loading

Fixes #7946

Signed-off-by: Jhon Honce jhonce@redhat.com

@jwhonce jwhonce added the kind/bug Categorizes issue or PR as related to a bug. label Oct 9, 2020
@jwhonce jwhonce self-assigned this Oct 9, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2020
@mheon
Copy link
Member

mheon commented Oct 9, 2020

LGTM

@jwhonce
Copy link
Member Author

jwhonce commented Oct 9, 2020

/retest

@jwhonce
Copy link
Member Author

jwhonce commented Oct 9, 2020

/test all

@openshift-ci-robot
Copy link
Collaborator

@jwhonce: No presubmit jobs available for containers/podman@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jwhonce
Monitor for client closing stream
0cdb104 
Fixes containers#7946

Signed-off-by: Jhon Honce <jhonce@redhat.com>
@TomSweeneyRedHat
Copy link
Member

LGTM
assuming happy tests

@rhatdan
Copy link
Member

rhatdan commented Oct 10, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit 36d5ab5 into containers:master Oct 10, 2020
@edsantiago edsantiago mentioned this pull request Oct 19, 2020
Closed
@garrett garrett mentioned this pull request Dec 2, 2020
Closed
@jwhonce jwhonce deleted the issues/7946 branch June 30, 2021 16:11
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jwhonce jwhonce

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API service is using 100% cpu
6 participants
@jwhonce @openshift-ci-robot @mheon @TomSweeneyRedHat @rhatdan @openshift-merge-robot