-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include CNI networks in inspect output when not running #7983
Include CNI networks in inspect output when not running #7983
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@baude PTAL |
LGTM once tests are happy |
changes LGTM, but tests look to be having some real issues. |
We were only including the CNI Network fields in the output of `podman inspect` when the container was not running. It's simple enough to fix (populate with empty structs, since we can't fill anything without a CNI response to get IP address assigned, etc). This is necessary for Docker compatibility. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
41b4bc3
to
77033c4
Compare
Restarting tests, looks like it was mostly flakes in uploading artifacts? |
/hold |
/lgtm |
/hold cancel |
We were only including the CNI Network fields in the output of
podman inspect
when the container was not running. It's simple enough to fix (populate with empty structs, since we can't fill anything without a CNI response to get IP address assigned, etc).This is necessary for Docker compatibility.