Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] Fix documentation link and typo #7977

Merged
merged 1 commit into from
Oct 10, 2020
Merged

[CI:DOCS] Fix documentation link and typo #7977

merged 1 commit into from
Oct 10, 2020

Conversation

stefanrua
Copy link
Contributor

Signed-off-by: Stefan Rua stefan.rua@iki.fi

@stefanrua
Fix documentation link and typo
b115e3e 
Signed-off-by: Stefan Rua <stefan.rua@iki.fi>
@rhatdan
Copy link
Member

rhatdan commented Oct 9, 2020

Thanks @stefanrua
I am no expert on the syntax but this seems to make sense
LGTM

@stefanrua
Copy link
Contributor Author

I'm not familiar with the syntax either, I just imitated the working links. I hope that someone familiar with it can confirm.

@jwhonce jwhonce changed the title Fix documentation link and typo [CI:DOCS] Fix documentation link and typo Oct 9, 2020
@TomSweeneyRedHat
Copy link
Member

LGTM
the Underscore turns the listed command into a link to the manpage.

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@TomSweeneyRedHat
Copy link
Member

and TYVM @stefanrua !

@stefanrua
Copy link
Contributor Author

No problem :)

@zhangguanzhang
Copy link
Collaborator

/approve

1 similar comment
@rhatdan
Copy link
Member

rhatdan commented Oct 10, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, stefanrua, zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6f5867b into containers:master Oct 10, 2020
@edsantiago edsantiago mentioned this pull request Oct 19, 2020
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@TomSweeneyRedHat TomSweeneyRedHat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stefanrua @rhatdan @TomSweeneyRedHat @zhangguanzhang @openshift-ci-robot @openshift-merge-robot