Container detach newlines #7955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libpod/image/pull.go
Outdated
| @@ -333,6 +333,8 @@ func (ir *Runtime) doPullImage(ctx context.Context, sc *types.SystemContext, goa | |||
| copyOptions.SourceCtx.SystemRegistriesConfPath = systemRegistriesConfPath // FIXME: Set this more globally. Probably no reason not to have it in every types.SystemContext, and to compute the value just once in one place. | |||
| // Print the following statement only when pulling from a docker or atomic registry | |||
| if writer != nil && (imageInfo.srcRef.Transport().Name() == DockerTransport || imageInfo.srcRef.Transport().Name() == AtomicTransport) { | |||
| io.WriteString(writer, fmt.Sprintf("Got Here")) | |||
There was a problem hiding this comment.
assuming this was a debug message that should have been removed?
There was a problem hiding this comment.
Whoops! let me clean up that commit
Signed-off-by: Parker Van Roy <pvanroy@redhat.com>
|
LGTM |
|
LGTM, I prefer this over #7953 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, ParkerVR The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
@ParkerVR I don't get a newline if I detach from |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #7751
alternative to #7953
this is not Docker compatible, which strangely results differently on 'docker run -it ' and 'docker attach '
This prints a \n on all container detaches to avoid the issues brought up in 7751
I believe this is a more logical solution although it is not the exact Docker activity