Container detach message (Docker Consistency) #7953
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ParkerVR The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pkg/domain/infra/abi/containers.go
Outdated
| @@ -312,7 +312,7 @@ func (ic *ContainerEngine) ContainerRm(ctx context.Context, namesOrIds []string, | |||
| reports = append(reports, &report) | |||
| continue | |||
| } | |||
| report.Err = errors.Wrapf(err, "failed to evict container: %q", id) | |||
| report.Err = errors.Wrapf(err, "Failed to evict container: %q", id) | |||
There was a problem hiding this comment.
error elements should start with lowercase not uppercase. If you need this exception for compatibility please add a comment.
pkg/domain/infra/abi/containers.go
Outdated
| @@ -604,7 +605,7 @@ func checkExecPreserveFDs(options entities.ExecOptions) error { | |||
| if options.PreserveFDs > 0 { | |||
| entries, err := ioutil.ReadDir("/proc/self/fd") | |||
| if err != nil { | |||
| return err | |||
| return errors.Wrapf(err, "unable to read /proc/self/fd") | |||
There was a problem hiding this comment.
Doesn't ioutil give you this information in ReadDir
There was a problem hiding this comment.
package main
import (
"fmt"
"io/ioutil"
)
func main() {
_, err := ioutil.ReadDir("/tmp/missing")
fmt.Println(err)
}
go run /tmp/t.go
open /tmp/missing: no such file or directory
Signed-off-by: Parker Van Roy <pvanroy@redhat.com>
ParkerVR
force-pushed
the
7751-newline
branch
from
4873c89
to
5a8864a
Compare
|
@ParkerVR Needs a rebase. |
|
determined necessary, an alternative method was used (#7955) |
github-actions
bot
added
the
locked - please file new issue/PR
For #7751
After a 'docker attach', <ctrl+p> <ctrl+q> detaches with message 'read escape sequence'. This was not occurring for me on 'docker run -it' or 'podman run -it' so I modified the podman behavior so this occurs only on attach as well.