Attempt to turn on some more remote tests #7845
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
rhatdan
force-pushed
the
remote
branch
13 times, most recently
from
26b4f0a
to
4b7a8c4
Compare
|
@containers/podman-maintainers PTAL |
| Expect(podman1.ExitCode()).To(Equal(125)) | ||
| Expect(podman1.ErrorToString()).To(ContainSubstring("unknown flag: --namespace")) | ||
| return | ||
| } |
There was a problem hiding this comment.
Silly question, but why not move the if IsRemote() down a couple of lines, and avoid duplicating the command & wait?
podman1.WaitWithDefaultTimeout()
if IsRemote() {
Expect(125) // and message
} else {
Expect(0) // and message
}
test/e2e/run_env_test.go
Outdated
| SkipIfRemote("FIXME, We should check that --env-host reports correct error on podman-remote") | ||
| if IsRemote() { | ||
| env := append(os.Environ(), "FOO=BAR") | ||
| session := podmanTest.PodmanAsUser([]string{"run", "--rm", "--env-host", ALPINE, "/bin/printenv", "FOO"}, 0, 0, "", env) |
There was a problem hiding this comment.
Similar to above, can we eliminate some duplication?
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| @@ -237,7 +237,7 @@ registries = ['{{.Host}}:{{.Port}}']` | |||
| }) | |||
|
|
|||
| It("podman search attempts HTTP if registry is in registries.insecure and force secure is false", func() { | |||
| SkipIfRemote("FIXME This should work on podman-remote") | |||
| SkipIfRemote("--tls-verify is not supportedon podman-remote search") | |||
There was a problem hiding this comment.
[not worth re-pushing; please fix only if something else merits it] : "supportedon" needs space. Also lines 281, 320 below.
| if is_remote; then | ||
| ENVHOST="" | ||
| else | ||
| ENVHOST="--env-host" |
There was a problem hiding this comment.
[another not-worth-pushing-just-for-this]: inconsistent indentation
| session = podmanTest.Podman([]string{"images", "-q"}) | ||
| session.WaitWithDefaultTimeout() | ||
| Expect(session.ExitCode()).To(Equal(0)) | ||
| totImages := strconv.Itoa(len(session.OutputToStringArray())) |
There was a problem hiding this comment.
Thank you! That has bitten us before.
Purely out of curiosity, is it ever possible for this number to be different from podman info --format '{{.Store.ImageStore.Number}}'?
|
This must've been incredibly tedious, iterating over and over so many tests. It is much appreciated. LGTM. |
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Signed-off-by: Daniel J Walsh dwalsh@redhat.com