Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abi: fix detection for systemd #7339

Merged

Conversation

giuseppe
Copy link
Member

create a scope everytime we don't own the current cgroup and we are
running on systemd, regardless of the config manager specified.

Closes: #6734

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2020
@rhatdan
Copy link
Member

rhatdan commented Aug 17, 2020

@mheon
Copy link
Member

mheon commented Aug 17, 2020

LGTM

@rhatdan
Copy link
Member

rhatdan commented Aug 17, 2020

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2020
@giuseppe
Copy link
Member Author

/retest

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2020
@rhatdan
Copy link
Member

rhatdan commented Aug 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2020
@edsantiago
Copy link
Member

rebase on master >= 748e882 to fix CI. I am sorry for the inconvenience.

create a scope everytime we don't own the current cgroup and we are
running on systemd.

Closes: containers#6734

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2020
@giuseppe
Copy link
Member Author

rebased

@mheon
Copy link
Member

mheon commented Aug 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2020
@rhatdan
Copy link
Member

rhatdan commented Aug 18, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7995f85 into containers:master Aug 18, 2020
adelton added a commit to adelton/freeipa-container that referenced this pull request Sep 5, 2020
adelton added a commit to adelton/freeipa-container that referenced this pull request Sep 5, 2020
adelton added a commit to adelton/freeipa-container that referenced this pull request Sep 5, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After podman 2 upgrade, systemd fails to start in containers on cgroups v1 hosts
7 participants