Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 copy endpoints #6356

Merged
merged 1 commit into from
May 30, 2020
Merged

Conversation

baude
Copy link
Member

@baude baude commented May 22, 2020

add copy endpoint inputs and outputs. these endpoints are not implemented yet, nor are any bindings. this allows us to update this later without having to change our api version.

Signed-off-by: Brent Baude bbaude@redhat.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2020
@baude baude force-pushed the v2copyendpoints branch 2 times, most recently from 4645380 to 463e2ef Compare May 22, 2020 18:58
@jwhonce
Copy link
Member

jwhonce commented May 23, 2020

LGTM Swagger verify tool expects one verb per endpoint. It either needs a skip or update.

pkg/api/server/register_archive.go Outdated Show resolved Hide resolved
pkg/api/server/register_archive.go Outdated Show resolved Hide resolved
add copy endpoint inputs and outputs.  these endpoints are not implemented yet, nor are any bindings.  this allows us to update this later without having to change our api version.

Signed-off-by: Brent Baude <bbaude@redhat.com>
@vrothberg
Copy link
Member

I opened #6406 for the podman stats flake.

@rhatdan
Copy link
Member

rhatdan commented May 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2020
@openshift-merge-robot openshift-merge-robot merged commit c479d63 into containers:master May 30, 2020
@baude baude deleted the v2copyendpoints branch May 18, 2022 15:20
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants