Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify v2 API testing for podman vs docker clients #13374

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions contrib/cirrus/runner.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,11 @@ function _run_unit() {
}

function _run_apiv2() {
make localapiv2 |& logformatter
local m="Testing of API was performed using the **PODMAN*** client"
warn "$m"
if ! make localapiv2 |& logformatter; then
die "$m"
fi
}

function _run_compose() {
Expand Down Expand Up @@ -96,8 +100,12 @@ function _run_bindings() {
}

function _run_docker-py() {
m="Testing of API was performed using the **DOCKER** client"
warn "$m"
source venv/bin/activate
make run-docker-py-tests
if ! make run-docker-py-tests; then
cevich marked this conversation as resolved.
Show resolved Hide resolved
die "$m"
fi
}

function _run_endpoint() {
Expand Down