Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify v2 API testing for podman vs docker clients #13374

Merged

Conversation

cevich
Copy link
Member

@cevich cevich commented Feb 28, 2022

Fixes: #13273

@cevich cevich requested a review from jwhonce February 28, 2022 17:14
Copy link
Member

@jwhonce jwhonce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on Ghost Rider, while the tests could be better laid out -- python/docker tests use DockerClient NOT PodmanClient. Given discussions in the group we may want to extend these tests not remove them.

@cevich
Copy link
Member Author

cevich commented Feb 28, 2022

Hold on Ghost Rider,

That's what I half-suspected, thanks for clarifying. Okay, let me re-push a new version of this that tries to make the situation more clear. Along those lines, is there something that can be done in the actual tests to show which client is being used? I'm assuming our setup is correct...but I'd prefer not to assume if I can be told for sure.

@cevich cevich changed the title Fix duplicate docker-py testing Clarify v2 API testing for podman vs docker clients Feb 28, 2022
@cevich cevich requested a review from jwhonce February 28, 2022 17:51
@cevich cevich force-pushed the fix_dupe_docker_testing branch 2 times, most recently from ddfcf69 to cff45fe Compare February 28, 2022 18:12
Fixes: containers#13273

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich
Copy link
Member Author

cevich commented Feb 28, 2022

Okay there, that should be much better. Now there's always a message or warning visible no matter if the python-traceback occupies an 10-screenfulls or not 😄

@cevich
Copy link
Member Author

cevich commented Feb 28, 2022

K, this should be good-to-go.

@TomSweeneyRedHat
Copy link
Member

LGTM

@rhatdan
Copy link
Member

rhatdan commented Feb 28, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2022
@rhatdan
Copy link
Member

rhatdan commented Feb 28, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit 86a057e into containers:main Feb 28, 2022
@cevich cevich deleted the fix_dupe_docker_testing branch April 18, 2023 14:51
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate docker-python testing in CI
6 participants