Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO TESTS NEEDED] Fix #11418 - Default TMPDIR to /tmp on OS X #11437

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

MichaelAnckaert
Copy link
Contributor

This PR fixes bug #11418 - on OS X there was a bug where podman would fail when the TMPDIR environment variable was empty.

This commit fixes that issue by defaulting to /tmp when that environment variable is empty.

@mheon
Copy link
Member

mheon commented Sep 3, 2021

pkg/machine/qemu/options_darwin.go:6:2: imported and not used: "github.com/pkg/errors"

Can you remove the github.com/pkg/errors import from that file to fix CI? Also, I've added [NO TESTS NEEDED] to your PR title to fix CI complaining that you did not add a test.

@mheon mheon changed the title Fix #11418 - Default TMPDIR to /tmp on OS X [NO TESTS NEEDED] Fix #11418 - Default TMPDIR to /tmp on OS X Sep 3, 2021
Copy link

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it not be like ~/tmp as /tmp my not be user writable ?

Signed-off-by: Michael Anckaert <michael.anckaert@sinax.be>
@MichaelAnckaert
Copy link
Contributor Author

@maxandersen The /tmp directory is also used on OS X and my research seems to indicate that this is always present in all cases.

I updated the changes to remove the unused import.

@rhatdan
Copy link
Member

rhatdan commented Sep 4, 2021

/approve
LGTM
@baude @ashley-cui @jwhonce PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MichaelAnckaert, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2021
@jwhonce
Copy link
Member

jwhonce commented Sep 7, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2021
@openshift-merge-robot openshift-merge-robot merged commit c9646b5 into containers:main Sep 7, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants