Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFE] podman kill --cidfile #8443

Closed
TerraTech opened this issue Nov 22, 2020 · 4 comments · Fixed by #8820
Closed

[RFE] podman kill --cidfile #8443

TerraTech opened this issue Nov 22, 2020 · 4 comments · Fixed by #8820
Assignees
@baude
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@TerraTech
Copy link

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind feature

Description

podman version: 2.1.1
Ubuntu: 20.04 LTS server

I would like to request podman kill be outfitted with reading container id via --cidfile

This is useful in Systemd services for ExecReload, e.g.
ExecReload=/usr/bin/podman kill --signal HUP --cidfile %t/%n.ctr-id

Actually, I was sort of surprised this didn't already exist, like it is for run and stop.

Thank you for your consideration.
@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 22, 2020
@rhatdan
Copy link
Member

rhatdan commented Nov 23, 2020

Interested in opening a PR to add this functionality?

@rhatdan rhatdan added the Good First Issue This issue would be a good issue for a first time contributor to undertake. label Nov 23, 2020
@TerraTech
Copy link
Author

Sure, doesn't seem like it would be difficult to implement along with being an itch that really needs to be scratched. ;)

@rhatdan rhatdan added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Nov 24, 2020
@rhatdan
Copy link
Member

rhatdan commented Nov 24, 2020

Thanks, Looking forward to seeing it.

@baude
Copy link
Member

baude commented Dec 23, 2020

@TerraTech i hope you dont mind that i made a pr for this ...

baude added a commit to baude/podman that referenced this issue Dec 23, 2020
@baude
add --cidfile to container kill
6bc66b7 
Add the ability to read container ids from one or more files for the
kill command.

Fixes: containers#8443

Signed-off-by: baude <bbaude@redhat.com>
@baude baude mentioned this issue Dec 23, 2020
Merged
baude added a commit to baude/podman that referenced this issue Dec 23, 2020
@baude
add --cidfile to container kill
e1d80ba 
Add the ability to read container ids from one or more files for the
kill command.

Fixes: containers#8443

Signed-off-by: baude <bbaude@redhat.com>
baude added a commit to baude/podman that referenced this issue Dec 23, 2020
@baude
add --cidfile to container kill
c81e295 
Add the ability to read container ids from one or more files for the
kill command.

Fixes: containers#8443

Signed-off-by: baude <bbaude@redhat.com>
@rhatdan rhatdan assigned baude and unassigned TerraTech Dec 23, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@baude baude

Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add --cidfile to container kill baude/podman
4 participants
@TerraTech @rhatdan @baude @openshift-ci-robot