Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv2: 'resize' resizes always to 80 characters #7102

Closed
marusak opened this issue Jul 28, 2020 · 5 comments · Fixed by #8858
Closed

APIv2: 'resize' resizes always to 80 characters #7102

marusak opened this issue Jul 28, 2020 · 5 comments · Fixed by #8858
Assignees
Labels
HTTP API Bug is in RESTful API In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@marusak
Copy link
Contributor

marusak commented Jul 28, 2020

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description
Using containers/resize or exec/resize to resize TTY session ignores w parameter and resizes always to 80 characters.

Steps to reproduce the issue:

sudo podman run -dt fedora bash
7d481626f41cec219a377c7fb20be9e25d37f9965e9e7e868b9361952ddef597
  1. sudo podman attach 7d481626f41cec219a377c7fb20be9e25d37f9965e9e7e868b9361952ddef597 and just type more than 80 characters. You should be able to type as many, as you want.

  2. run in different terminal sudo curl -X POST --unix-socket /run/podman/podman.sock "http://d/v1.24/libpod/containers/7d481626f41cec219a377c7fb20be9e25d37f9965e9e7e868b9361952ddef597/resize?w=200&h=20" and then in the one where you are still attached you can type only 80 characters and then the line will start to overwrite itself. Feels like the w is ignored and 80 is used as default value?

Output of podman version:

Version:      2.0.2
API Version:  1
Go Version:   go1.14.3
Built:        Thu Jan  1 01:00:00 1970
OS/Arch:      linux/amd64

Package info (e.g. output of rpm -q podman or apt list podman):

podman-2.0.2-1.fc32.x86_64
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 28, 2020
@mheon mheon added the HTTP API Bug is in RESTful API label Jul 28, 2020
@rhatdan
Copy link
Member

rhatdan commented Jul 28, 2020

@jwhonce PTAL

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Aug 28, 2020

@ashley-cui PTAL

@rhatdan rhatdan assigned ashley-cui and mheon and unassigned ashley-cui Sep 10, 2020
@rhatdan
Copy link
Member

rhatdan commented Dec 24, 2020

@jwhonce What is going on with this?

@rhatdan
Copy link
Member

rhatdan commented Dec 24, 2020

@containers/podman-maintainers PTAL
It does not seem like this should be a big issue? Is this fairly easy to fix?

@jwhonce jwhonce added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Dec 31, 2020
jwhonce added a commit to jwhonce/podman that referenced this issue Dec 31, 2020
Fixes containers#7102

Signed-off-by: Jhon Honce <jhonce@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
HTTP API Bug is in RESTful API In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants