Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate kube: Do not print spec.containers.command, if it is the default entrypoint of the image #11915

Closed
dilyanpalauzov opened this issue Oct 11, 2021 · 5 comments · Fixed by #11947
Assignees
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@dilyanpalauzov
Copy link
Contributor

At #11672 I asked to alter podman generate kube not to print variables, which were not part of the container and not to print spec.containers.command. podman 3.4.0 still prints on podman generate kube the command, even if it is the default commant/entrypoint contained in the image.

As test case I use the instructions from https://mail.aegee.org/cgit/aegee-ldap/tree/readme.md#n13.

@umohnani8
Copy link
Member

@dilyanpalauzov to verify, you are saying if the default command/entrypoint defined in the image is used when running the container, it should not show up in the generated kube yaml? Only the command that the user passes in via the command line when doing a podman run should show up in the kube yaml?

So if my image has the command sleep 1000 and I do podman run myimage ls then ls should show up in the kube yaml, but if I just do podman run myimage then nothing should show up under command in the kube yaml?

@umohnani8 umohnani8 self-assigned this Oct 11, 2021
@dilyanpalauzov
Copy link
Contributor Author

Exactly.

@Luap99
Copy link
Member

Luap99 commented Oct 11, 2021

This was already fixed in #11704

@Luap99 Luap99 closed this as completed Oct 11, 2021
@dilyanpalauzov
Copy link
Contributor Author

As mentioned at #11672 (comment) , I tried it, and it does not work for me.

@Luap99
Copy link
Member

Luap99 commented Oct 11, 2021

I see it only works for command but not the entrypoint.

@Luap99 Luap99 reopened this Oct 11, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants