Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[additionalimagestores] Simplify --storage-opt/--root syntax #10393

Closed
srcshelton opened this issue May 18, 2021 · 0 comments · Fixed by #10400
Closed

[additionalimagestores] Simplify --storage-opt/--root syntax #10393

srcshelton opened this issue May 18, 2021 · 0 comments · Fixed by #10400
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@srcshelton
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind feature

Description

Currently, the --root option appears to have little functionality without also specifying --storage-opt= to clear the existing storage configuration (which includes the default root).

If use of --root implied --storage-opt= --root then podman's syntax would be clearer.

Note, however, that podman currently doesn't accept, e.g.

--storage-opt= --storage-opt="overlay.imagestore=<dir2>" --root <dir1>

(… as an error is generated), so either this would need to be relaxed or --root should only imply --storage-opt= if no additional --storage-opt value is specified.

A further enhancement would be to provide an option such as --swap-root <dir> or --root-swap <dir> which would be equivalent to:

podman --storage-opt="overlay.imagestore=${GRAPH_ROOT}" --root "${IMAGE_ROOT}"

(e.g. operate on a specified additiopalimagestore location but retain access to resources in the default graphRoot store)

Finally, since multiple additionalimagestore locations can be defined, the above syntax would be ideal to represent the case there one of the additional stores should be promoted to being the main store, whilst retaining access to both the original main store and all other defined additional stores.

See #9852 for further context.

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label May 18, 2021
rhatdan added a commit to rhatdan/podman that referenced this issue May 19, 2021
Fixes: containers#10393

Currently if a user specifies a --root flag to override the location of
the container storage, we still enforce the storage-opts from
storage.conf. This causes issues with people trying to intereact with
the additional stores feature, and then forces them to use the obscure
--storage-opt="" option. I belive this should be the default and we
already do this when the user specifies the --storage-driver option.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/podman that referenced this issue May 19, 2021
Fixes: containers#10393

Currently if a user specifies a --root flag to override the location of
the container storage, we still enforce the storage-opts from
storage.conf. This causes issues with people trying to intereact with
the additional stores feature, and then forces them to use the obscure
--storage-opt="" option. I belive this should be the default and we
already do this when the user specifies the --storage-driver option.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/podman that referenced this issue May 19, 2021
Fixes: containers#10393

Currently if a user specifies a --root flag to override the location of
the container storage, we still enforce the storage-opts from
storage.conf. This causes issues with people trying to intereact with
the additional stores feature, and then forces them to use the obscure
--storage-opt="" option. I belive this should be the default and we
already do this when the user specifies the --storage-driver option.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/podman that referenced this issue May 19, 2021
Fixes: containers#10393

Currently if a user specifies a --root flag to override the location of
the container storage, we still enforce the storage-opts from
storage.conf. This causes issues with people trying to intereact with
the additional stores feature, and then forces them to use the obscure
--storage-opt="" option. I belive this should be the default and we
already do this when the user specifies the --storage-driver option.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Procyhon pushed a commit to Procyhon/podman that referenced this issue May 27, 2021
Fixes: containers#10393

Currently if a user specifies a --root flag to override the location of
the container storage, we still enforce the storage-opts from
storage.conf. This causes issues with people trying to intereact with
the additional stores feature, and then forces them to use the obscure
--storage-opt="" option. I belive this should be the default and we
already do this when the user specifies the --storage-driver option.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant