-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Podman run blocks in isPathOnVolume
function forever
#10216
Labels
kind/bug
Categorizes issue or PR as related to a bug.
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
Comments
openshift-ci-robot
added
the
kind/bug
Categorizes issue or PR as related to a bug.
label
May 5, 2021
The simplest fix would be something like this:
which should ensure that it would never loop forever in that code. But also IMHO it would be nice to have some validation for |
@vrothberg PTAL |
@bacher09 Please open a PR to fix this? |
bacher09
added a commit
to bacher09/podman
that referenced
this issue
May 5, 2021
filepath.Dir in some cases returns `.` symbol and calling this function again returns same result. In such cases this function never returns and causes some operations to stuck forever. Closes containers#10216
bacher09
added a commit
to bacher09/podman
that referenced
this issue
May 5, 2021
filepath.Dir in some cases returns `.` symbol and calling this function again returns same result. In such cases this function never returns and causes some operations to stuck forever. Closes containers#10216 Signed-off-by: Slava Bacherikov <slava@bacher09.org>
bacher09
added a commit
to bacher09/podman
that referenced
this issue
May 6, 2021
filepath.Dir in some cases returns `.` symbol and calling this function again returns same result. In such cases this function never returns and causes some operations to stuck forever. Closes containers#10216 Signed-off-by: Slava Bacherikov <slava@bacher09.org>
bacher09
added a commit
to bacher09/podman
that referenced
this issue
May 6, 2021
filepath.Dir in some cases returns `.` symbol and calling this function again returns same result. In such cases this function never returns and causes some operations to stuck forever. Closes containers#10216 Signed-off-by: Slava Bacherikov <slava@bacher09.org>
bacher09
added a commit
to bacher09/podman
that referenced
this issue
May 6, 2021
filepath.Dir in some cases returns `.` symbol and calling this function again returns same result. In such cases this function never returns and causes some operations to stuck forever. Closes containers#10216 Signed-off-by: Slava Bacherikov <slava@bacher09.org>
github-actions
bot
added
the
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
label
Sep 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
kind/bug
Categorizes issue or PR as related to a bug.
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
There is a bug in current isPathOnVolume function which in some cases leads to infinite loop which causes some commands to stuck. This happens cause
filepath.Dir(dest)
could return.
in some cases and calling same method again would return same result (.
).Steps to reproduce the issue:
Dockerfile
:it can be compiled using any tool (I used original
docker build
).NOTE: that
VOLUME
uses single quotes'
and not"
.Pull that image into your system and make it available for
podman
Try to start that container using that image:
and this would stuck forever in the loop.
Describe the results you received:
podman run testimg
got stuck consuming cpu resources.Describe the results you expected:
It should either fail or succeed. Interestingly spec like this works fine in a
docker
, it also used to work in apodman
version 2.Extra information
Basically using single quotes causes
vol.Dest
to become[/etc/foo]
string and callingfilepath.Dir
on it will eventually return[
and then.
so will never match/
.I skipped some fields cause these are not really necessary cause issue is really issue to reproduce.
The text was updated successfully, but these errors were encountered: