Skip to content

Commit

Permalink
solves docker inconsistency for podman attach x
Browse files Browse the repository at this point in the history
Signed-off-by: Parker Van Roy <pvanroy@redhat.com>
  • Loading branch information
ParkerVR committed Oct 12, 2020
1 parent 212011f commit 5a8864a
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkg/domain/infra/abi/containers.go
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,9 @@ func (ic *ContainerEngine) ContainerAttach(ctx context.Context, nameOrID string,
if err != nil && errors.Cause(err) != define.ErrDetach {
return errors.Wrapf(err, "error attaching to container %s", ctr.ID())
}
// This write maintains compatibility with Docker on <ctrl+p> <ctrl+q> detach:
// 'run -it x' does not newline but 'attach x' prints this message and newlines
os.Stdout.WriteString("read escape sequence\n")
return nil
}

Expand Down

0 comments on commit 5a8864a

Please sign in to comment.