Don't use systemd defaults if /proc/1/comm != systemd #585
Conversation
Currently we have users failing to run containers within containers or on systems without systemd support. This change will give us better defaults on these systems. Fixes: containers#580 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
@giuseppe @vrothberg @mheon PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code LGTM but I think we need to do more to fix #580. At the moment we do a presence check but we do not yet do an access check.
The access check is important to improve on the error reporting. For instance, if the environment is not set up correctly (XDG_, DBUS_, etc.), Podman can fail at various places. If those are set but the user isn't in the right group to access DBUS, Podman can fail again at various places.
Checking that here would be amazing
Currently we have users failing to run containers within containers
or on systems without systemd support. This change will give us
better defaults on these systems.
Fixes: #580
Signed-off-by: Daniel J Walsh dwalsh@redhat.com