Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build backend from flit to hatchling #127

Merged
merged 6 commits into from
Feb 10, 2023
Merged

Change build backend from flit to hatchling #127

merged 6 commits into from
Feb 10, 2023

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Feb 4, 2023

Description

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

I forgot to update this attribute in the last release, so just fixing it now so it's clear in the future. Internally, conda-libmamba-solver.__version__ will report 22.8.1 til this is released. To be clear, conda list does report the correct version. This now uses hatchling plus a setuptools-scm plugin, hatch-vcs, as the build backend.

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Feb 4, 2023
@jezdez
Copy link
Member

jezdez commented Feb 6, 2023

@jaimergp We could switch to setuptools_scm via https://pypi.org/project/flit-scm/ or (while looking at pypa/flit#257) switch to PyPA's hatch instead that has setuptools_scm support?

@jaimergp
Copy link
Contributor Author

jaimergp commented Feb 7, 2023

We chose flit because back then it was the only solution that provided editable installs with a pyprojec.toml-only setup. If that has changed, then we can revisit that option. flit-scm looks simple enough to not break easily, despite being a "minor" project if compared with all the other backends.

Other alternatives include adding an extra step to the Release issue template, and manually update the version attribute as part of the "Prepare release" PR.

@jaimergp
Copy link
Contributor Author

jaimergp commented Feb 8, 2023

I tried all options locally and hatch-vcs fits the bill just fine!

@jaimergp jaimergp changed the title fix version attribute in __init__ Change build backend from flit to hatchling Feb 8, 2023
@jaimergp jaimergp marked this pull request as ready for review February 8, 2023 21:10
@jaimergp jaimergp linked an issue Feb 8, 2023 that may be closed by this pull request
2 tasks
@jaimergp jaimergp merged commit ce15fbf into main Feb 10, 2023
@jaimergp jaimergp deleted the fix-version branch February 10, 2023 14:09
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Feb 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Conda user-agent reports 22.8.1 is the current version
3 participants