Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipes for missing ignition libraries #13551

Closed
6 tasks done
traversaro opened this issue Dec 24, 2020 · 5 comments · Fixed by #14446
Closed
6 tasks done

Add recipes for missing ignition libraries #13551

traversaro opened this issue Dec 24, 2020 · 5 comments · Fixed by #14446

Comments

@traversaro
Copy link
Contributor

traversaro commented Dec 24, 2020

In few cases in the last months I had explain to interested users which ignition robotics libraries (a set of C++ libraries for robotics, see https://ignitionrobotics.org/) were still missing from conda-forge . As this info may be useful to anyone interested in this, especially for people interesting in adding the missing recipes, I think it is useful to report it and track it in this repo.

The Ignition libraries still not packaged in conda-forge are (see https://ignitionrobotics.org/libs for the complete list):

Note that the naming schema for Ignition libraries in conda forge is libignition-<library-name><major-version> .

cc @Tobias-Fischer @wolfv @mabelzhang @JShep1

@JShep1
Copy link

JShep1 commented Jan 13, 2021

I just opened a PR adding ign-rendering to conda-forge here.

Admittedly, it's my first contribution to conda-forge so I followed the contribution guidelines as closely as I could and there might be a few mistakes in that PR. But once I get the feedback and solidify the process, I'll open more PRs for the remaining packages.

Do you have any advice for me for that PR (like things I may have done wrong or who I need to ping to get it in)? @traversaro

@traversaro
Copy link
Contributor Author

Do you have any advice for me for that PR (like things I may have done wrong or who I need to ping to get it in)? @traversaro

Hi @JShep1 , thanks for working on the recipe. My suggestion is to iterate on the PR until the CI passes, and if you have any doubt feel free to ping me, @Tobias-Fischer or @wolfv . Once the PR is ready, you will need someone with merge permissions. For C/C++ libraries you can ping the @conda-forge/help-c-cpp, and in practice for robotics-related library I typically ping also @wolfv that as part of the core conda-forge team can merge new recipes.

@traversaro
Copy link
Contributor Author

traversaro commented Jan 13, 2021

If you have any quick question, feel free also to pass by https://gitter.im/RoboStack/Lobby .

@traversaro
Copy link
Contributor Author

This is completed with #14446 . If anyone is interested in this, for apt/homebrew feature parity, it could make sense to have a ignition-metackages-feedstock repo that produces all metapackages like ignition-dome, ignition-edifice that install all the versions corresponding to a given release, but I think the fundamental problem of having ignition libraries in conda-forge has been now fixed.

@wolfv
Copy link
Member

wolfv commented Apr 1, 2021

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants