From 09d07a3c08ffd939c6a17324bf9dbbce8702dc9c Mon Sep 17 00:00:00 2001
From: csavelief <csavelief@mncc.fr>
Date: Thu, 12 Sep 2024 16:05:45 +0200
Subject: [PATCH] Perf. on /vulnerabilities endpoint.

---
 .../AdversaryMeter/Http/Controllers/HoneypotController.php    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/Modules/AdversaryMeter/Http/Controllers/HoneypotController.php b/app/Modules/AdversaryMeter/Http/Controllers/HoneypotController.php
index 152afbc..830cdeb 100644
--- a/app/Modules/AdversaryMeter/Http/Controllers/HoneypotController.php
+++ b/app/Modules/AdversaryMeter/Http/Controllers/HoneypotController.php
@@ -104,13 +104,13 @@ public function getVulnerabilitiesWithAssetInfo(?int $attackerId = null): array
             ->join('scans', 'scans.id', '=', 'ports.scan_id')
             ->join('assets', 'assets.cur_scan_id', '=', 'scans.ports_scan_id')
             ->get()
-            ->filter(fn(Alert $alert) => !$attackerId || $alert->events($attackerId)->exists())
+            ->filter(fn(Alert $alert) => !$attackerId || !$alert->cve_id || $alert->events($attackerId)->exists())
             ->map(function (Alert $alert) use ($attackerId) {
                 return [
                     'alert' => $alert,
                     'asset' => $alert->asset(),
                     'port' => $alert->port(),
-                    'events' => $alert->events($attackerId)->get()->toArray(),
+                    'events' => $alert->cve_id ? $alert->events($attackerId)->get()->toArray() : [],
                 ];
             })
             ->toArray();