Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: support for a different address (remote) for CometBFT repository #78

Open
cason opened this issue Sep 29, 2023 · 0 comments
Open

Comments

@cason
Copy link

cason commented Sep 29, 2023

The Makefile currently downloads CometBFT's repository from its full HTTP address: https://github.com/cometbft/cometbft.git.

While this default behavior is possibly necessary, it should be possible to setup a different address (remote) from which to clone the repository. For instance, a local copy of it or a GIT remote address which is less affected by rate control.

The suggestion is to create a variable on Makefile, say COMETBFT_REMOTE. When it is set, the build role should clone the repository from the configured address. When not set, it should clone it from the above mentioned default remote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant