Use each instead of each_with_index in source_file.erb
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thank you for review and simplecov-html 0.10.1 release. It seems that the problem has been resolved and working. Thanks again! |
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Jun 5, 2017
0.10.1 2017-05-17 ======== ## Bugfixes * circumvent a regression that happens in the new JRuby 9.1.9.0 release. See [#53](simplecov-ruby/simplecov-html#53) thanks @koic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of
Enumerable#each_with_indexhas changed in JRuby 9.1.9.0.jruby/jruby#4610
This PR used
eachmethod because it do not use a block variable of index.The purpose of this change is to fix the following error at simplecov.
simplecov-ruby/simplecov#582
Thanks.