diff --git a/CHANGES.rst b/CHANGES.rst index 4224988..792332e 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -6,7 +6,8 @@ Changelog - Python 3, Plone 5.2 and Plone 6.0 compatible. [aduchene] - +- Fixed an issue when odt_file.filename could be None when searching and replacing. + [aduchene] 3.43 (2024-04-10) ----------------- diff --git a/setup.py b/setup.py index c62dd03..40c08d6 100644 --- a/setup.py +++ b/setup.py @@ -53,7 +53,7 @@ 'z3c.table', # fix about orderedselect 'z3c.form>=3.2.4', - 'imio.helpers>=0.57', + 'imio.helpers>=1.0', 'imio.migrator>=1.11' ], extras_require={ diff --git a/src/collective/documentgenerator/tests/test_search_replace.py b/src/collective/documentgenerator/tests/test_search_replace.py index 3cef2f5..5665142 100644 --- a/src/collective/documentgenerator/tests/test_search_replace.py +++ b/src/collective/documentgenerator/tests/test_search_replace.py @@ -417,3 +417,11 @@ def test_search_replace_control_panel_regex_validator(self): data = {"replacements": replacements} errors = form.widgets.validate(data) self.assertFalse(errors) + + def test_no_odt_file_or_no_filename(self): + self.template1.odt_file = None + self.template2.odt_file.filename = None + with SearchAndReplacePODTemplates((self.template1, self.template2)) as search_replace: + results = search_replace.search("view") + + self.assertEqual(len(results.keys()), 0)