Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

codecov-ruby breaks gems has a dependency for colorize #96

Closed
unhappychoice opened this issue Aug 27, 2020 · 0 comments · Fixed by #98
Closed

codecov-ruby breaks gems has a dependency for colorize #96

unhappychoice opened this issue Aug 27, 2020 · 0 comments · Fixed by #98

Comments

@unhappychoice
Copy link

unhappychoice commented Aug 27, 2020

Ref: circleci-tools/circleci-cli#217

First of all, thank you for this awesome product 🙏
I'm using codecov for almost all of my repositories.

Description

  1. My gem depended on both of colorize and codecov-ruby.
  2. codecov-ruby 0.2.8 ( Remove colorize depedency #94 ) overwrites colorize methods.
  3. My gem is broken.

Suggestion

I think gems used as a library should not monkey-patch the Ruby classes,
except in case of getting permission from users or getting things known to them at least.

So, I think we should use simple methods instead of monkey-patching String
( or use Refinement? But I don't think it's not worth using such a function for the colorize methods.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant