You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
I think gems used as a library should not monkey-patch the Ruby classes,
except in case of getting permission from users or getting things known to them at least.
So, I think we should use simple methods instead of monkey-patching String
( or use Refinement? But I don't think it's not worth using such a function for the colorize methods.
The text was updated successfully, but these errors were encountered:
Ref: circleci-tools/circleci-cli#217
First of all, thank you for this awesome product 🙏
I'm using codecov for almost all of my repositories.
Description
colorize
andcodecov-ruby
.codecov-ruby 0.2.8
( Remove colorize depedency #94 ) overwrites colorize methods.Suggestion
I think gems used as a library should not monkey-patch the Ruby classes,
except in case of getting permission from users or getting things known to them at least.
So, I think we should use simple methods instead of monkey-patching
String
( or use
Refinement
? But I don't think it's not worth using such a function for the colorize methods.The text was updated successfully, but these errors were encountered: