PackedCandidate::dzError should be dszError

[slava77]

In TrackBase.h

  inline double TrackBase::dzError() const { return error(i_dsz) * sqrt(p2() / pt2()); }

In PackedCandidate.h

float dzError() const override {
      maybeUnpackCovariance();
      return sqrt((*m_.load())(4, 4));

and that's saved directly from track as

  packedCovariance_.dzdz = packCovarianceElement(m, 4, 4);

@arizzi @cms-sw/tracking-pog-l2 @jordan-martins

We can just simply rename PackedCandidate::dzError to dszError. This will be more visible to users (the old code will not compile). Simply changing the implementation of PackedCandidate::dzError can become confusing.

TBD.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

A new Issue was created by @slava77.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[arizzi]

I'd say that's just a bug and we should fix it...

[arizzi]

PS: is the "bestTrack" correctly built? i.e. do I get the correct answer if I ask the bestTrack to the packedCandidate and then take dzError from there?

[makortel]

assign xpog

[cmsbuild]

New categories assigned: xpog

@vlimant,@hqucms,@ftorrresd you have been requested to review this Pull request/Issue and eventually sign? Thanks

[slava77]

PS: is the "bestTrack" correctly built? i.e. do I get the correct answer if I ask the bestTrack to the packedCandidate and then take dzError from there?

yes, bestTrack is OK.
It came up while comparing bestTrack variables with the equivalents available directly from the PackedCandidate

[slava77]

type tracking

[vlimant]

type pf