Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Fixed NotFound errors exceptions for some resources #965

Merged
merged 1 commit into from
May 31, 2022
Merged

fix: Fixed NotFound errors exceptions for some resources #965

merged 1 commit into from
May 31, 2022

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented May 31, 2022 •
edited
Loading

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

adds NotFound errors ignore in aws_apigateway_rest_apis aws_elbv2_listeners aws_kms_keys aws_lambda_functions aws_rds_cluster_snapshots

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

erezrokah
erezrokah approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@amanenk amanenk marked this pull request as ready for review May 31, 2022 09:55
@amanenk amanenk requested a review from a team as a code owner May 31, 2022 09:55
@amanenk amanenk requested review from shimonp21 and removed request for a team May 31, 2022 09:55
@amanenk amanenk merged commit d2cab56 into cloudquery:main May 31, 2022
@cq-bot cq-bot mentioned this pull request May 31, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Jun 1, 2022
@cq-bot
chore(main): Release v0.12.2 (#969)
ced8892 
🤖 I have created a release *beep* *boop*
---


### [0.12.2](v0.12.1...v0.12.2) (2022-06-01)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.10.6 ([#977](#977)) ([2baacf2](2baacf2))
* **errors:** Use `WithNoOverwrite` instead of `WithOptionalSeverity` ([#975](#975)) ([e6d2086](e6d2086))
* Fixed `NotFound` errors exceptions for some resources ([#965](#965)) ([d2cab56](d2cab56))
* Update endpoints ([#972](#972)) ([2af266a](2af266a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erezrokah erezrokah erezrokah approved these changes

@shimonp21 shimonp21 Awaiting requested review from shimonp21 shimonp21 is a code owner automatically assigned from cloudquery/cloudquery-opensource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanenk @erezrokah