Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING.md quality metric should not be case sensitive #1837

Closed
tas50 opened this issue Jan 2, 2020 · 0 comments · Fixed by #2180
Closed

CONTRIBUTING.md quality metric should not be case sensitive #1837

tas50 opened this issue Jan 2, 2020 · 0 comments · Fixed by #2180
Assignees
@RajeshPaul38
Labels
Component: Quality Metrics Involving fieri, the cookbook quality metrics feature

Comments

@tas50
Copy link
Contributor

tas50 commented Jan 2, 2020

Describe the problem

Right now if you upload a cookbook with a source_url we look for CONTRIBUTING.md in the repo. Our search is case sensitive so we fail if we find CONTRIBUTING.MD which github is quite OK with.

Software Version

Latest supermarket on the web

Replication Case

See:

https://supermarket.chef.io/cookbooks/mcelog#quality
https://github.com/chef-cookbooks/mcelog/blob/master/CONTRIBUTING.MD
@tas50 tas50 changed the title Contributing.md quality metro should not be case sensitive Contributing.md quality metric should not be case sensitive Jan 2, 2020
@tas50 tas50 changed the title Contributing.md quality metric should not be case sensitive CONTRIBUTING.md quality metric should not be case sensitive Jan 2, 2020
@tas50 tas50 added the Component: Quality Metrics Involving fieri, the cookbook quality metrics feature label Jul 5, 2021
@saghoshprogress saghoshprogress self-assigned this Aug 19, 2021
@RajeshPaul38 RajeshPaul38 mentioned this issue Aug 24, 2021
Merged
5 tasks
@RajeshPaul38 RajeshPaul38 linked a pull request Aug 24, 2021 that will close this issue
Made contributing.md file name check case insensitive in the cookbook source_url repo; Fixed github url regex; #2180
Merged
5 tasks
@RajeshPaul38 RajeshPaul38 mentioned this issue Sep 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RajeshPaul38 RajeshPaul38

Labels
Component: Quality Metrics Involving fieri, the cookbook quality metrics feature
Projects
None yet
Milestone
No milestone
3 participants
@tas50 @saghoshprogress @RajeshPaul38