-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
❗️omnibus build is broken #1817
Comments
Updated the internal cookbook to not depend on the unicorn-and-therefore-windows cookbook and still get the error. Unsure of which remaining cookbook has the extended headers. Seems the extract-with-RubyGems-TarReader is down in berkshelf's
|
I get the same error. Needs a fix quickly. |
@arhue You get the same error in what context? Are you building your own omnibus package of Supermarket? |
Hoping for a release of RubyGems 3.0.6 which should include a fix for large uid/gids in tarfiles, but that release is currently held up (at least partially) by another unrelated PR. More context: The error is coming from berkshelf's use of RubyGem's TarReader to unpack cookbook tarballs. RubyGem's TarReader could not handle large values in uid or gid header entries. In other places where this error appeared, we moved to using Chef-maintained ffi-libarchive in the places in the code that dive into tarballs. So far, we've decided against using ffi-libarchive in berkshelf because libarchive would introduce a C dependency which would make using berkshelf as a gem more complicated. |
Describe the problem
Builds of the omnibus package fail with:
Software Version
The master branch, starting with tag v3.3.6. There is no v3.3.6 version currently because the package cannot be built.
Replication Case
See https://buildkite.com/chef/chef-supermarket-master-omnibus-adhoc/builds/9#job-20de4140-a25d-4193-a7c5-d379eccea99f for an example failed run.
Stacktrace/Details
This occurs during the install of
supermarket-cookbooks
. Supermarket's omnibus-internal cookbook still uses berkshelf and seems to be pulling in a version that uses RubyGem's TarReader to expand cookbooks (see #1806 and #1810 for ugly details about why this happens). The chain of what's going on seems to be as follows:unicorn.rb.erb
template; no resources are used)Possible Solution
Some ideas:
unicorn.rb.erb
template and, if so, copy it into the internal cookbook, manage it ourselves, and drop the dependency on the unicorn cookbookThe text was updated successfully, but these errors were encountered: