Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup using name_attribute on a property #78

Closed
1 of 7 tasks
tas50 opened this issue Jul 15, 2019 · 1 comment
Closed
1 of 7 tasks

Fixup using name_attribute on a property #78

tas50 opened this issue Jul 15, 2019 · 1 comment
Labels
New Cop Proposal A proposal for a new Cookstyle cop

Comments

@tas50
Copy link
Contributor

tas50 commented Jul 15, 2019 •
edited
Loading

What category of cop is this?:

Please try to select as few as possible.

  • Deprecation - A cop that alerts to a deprecation in the Chef Infra Client
  • Correctness - A cop that alerts when incorrect coding behavior is being used
  • Sharing - A cop that alerts to missing functionality necessary for sharing cookboooks with others
  • Style - A cop that alerts to a style best practice
  • Simplification - A cop that alerts to ways code can be simplified through refactoring
  • Effortless - A cop that alerts on code that must be resolved to move to the Effortless pattern
  • Policyfiles - A cop that alerts on code that must be resolved to move to the Policyfiles pattern

Describe the new cop:

When people migrate a LWRP to a custom resource they often miss some of the attribute -> property migrations

What it would trigger on:

property :something, String, name_attribute: true

What it would autocorrect to if applicable

property :something, String, name_property: true
@tas50 tas50 added the Status: Untriaged An issue that has yet to be triaged. label Jul 15, 2019
@tas50 tas50 added New Cop Proposal A proposal for a new Cookstyle cop and removed Status: Untriaged An issue that has yet to be triaged. New Cop Proposal A proposal for a new Cookstyle cop labels Jul 24, 2019
@tas50 tas50 changed the title Fixup missing attribute and property in a resource Fixup using name_attribute on a property Jul 24, 2019
@tas50
Copy link
Contributor Author

tas50 commented Jul 24, 2019

Fixed by #125

@tas50 tas50 closed this as completed Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
New Cop Proposal A proposal for a new Cookstyle cop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tas50