From ae8d4c56f157f2bb1d937f9cb084a729642154ac Mon Sep 17 00:00:00 2001 From: Tim Smith Date: Wed, 5 Aug 2020 10:36:09 -0700 Subject: [PATCH 1/2] Turn off Naming/AccessorMethodName This isn't a thing folks should worry about in cookbooks. There's more pressing issues. Signed-off-by: Tim Smith --- config/cookstyle.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/config/cookstyle.yml b/config/cookstyle.yml index 4e670e9ef..4c1418918 100644 --- a/config/cookstyle.yml +++ b/config/cookstyle.yml @@ -2575,3 +2575,7 @@ Style/HashEachMethods: # We want to catch this deprecation in cookbooks Lint/DeprecatedOpenSSLConstant: Enabled: true + +# This just isn't a big deal in the context of a cookbook +Naming/AccessorMethodName: + Enabled: false \ No newline at end of file From 204776f7b804a8aff8ebc02896d4c85f2fe7e6fe Mon Sep 17 00:00:00 2001 From: Tim Smith Date: Wed, 5 Aug 2020 10:37:58 -0700 Subject: [PATCH 2/2] Remove comments that are now incorrect Signed-off-by: Tim Smith --- config/cookstyle.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/config/cookstyle.yml b/config/cookstyle.yml index 4c1418918..81b9430b4 100644 --- a/config/cookstyle.yml +++ b/config/cookstyle.yml @@ -2342,15 +2342,11 @@ Metrics/BlockNesting: Metrics/ParameterLists: Enabled: false -#### COPS FOR THE NEXT MAJOR RELEASE - # This updates how we send helpers into the Chef recipe/resource classes and makes WAY more sense # Chef::Recipe.send(:include, ::Apt::Helpers) -> Chef::Recipe.include ::Apt::Helpers Lint/SendWithMixinArgument: Enabled: true -#### END COPS FOR THE NEXT MAJOR RELEASE - # this migrates old # rubocop: comments to use the latest namespaces, which prevents a ton of spam during cookstyle runs Migration/DepartmentName: Enabled: true