chore: Update spaital analytics #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tihuan
commented
Jun 18, 2024
| const { camera } = this.state; | ||
|
|
||
| camera?.goHome(this.openseadragon); | ||
| this.renderCanvas(); | ||
| }; | ||
|
|
||
| handleRecenterButtonClick = () => { |
There was a problem hiding this comment.
create an explicit button click handler, so the tracking event can happen exclusively at click time
| @@ -418,7 +423,7 @@ class Graph extends React.Component<GraphProps, GraphState> { | |||
| } | |||
| }; | |||
|
|
|||
| handleBrushDragAction(): void { | |||
| async handleBrushDragAction(): Promise<void> { | |||
There was a problem hiding this comment.
bunch of methods that are not awaiting the promises according to the new lint rule
| imageUnderlay | ||
| ? EVENTS.EXPLORER_IMAGE_SELECT |
There was a problem hiding this comment.
flip the event names
| @@ -36,7 +36,7 @@ const catLabelSort = ( | |||
| const ints: (string | number | boolean)[] = []; | |||
| const unassignedOrNaN: (string | number | boolean)[] = []; | |||
|
|
|||
| values.forEach((v) => { | |||
| values?.forEach((v) => { | |||
There was a problem hiding this comment.
coincidentally caught this bug when the left side bar failed to load the categories
kaloster
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.