chore: misc typing #849
Merged
chore: misc typing #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seve
commented
Mar 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
=======================================
Coverage 76.57% 76.57%
=======================================
Files 88 88
Lines 6994 6994
=======================================
Hits 5356 5356
Misses 1638 1638
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tihuan
reviewed
Mar 25, 2024
| @@ -16,7 +16,7 @@ | |||
| "e2e-stage": "CXG_URL_BASE=https://cellxgene.staging.single-cell.czi.technology playwright test", | |||
| "e2e-prod": "CXG_URL_BASE=https://cellxgene.cziscience.com playwright test", | |||
| "fmt": "eslint --fix src __tests__", | |||
| "lint": "eslint src __tests__ & npm run type-check", | |||
| "lint": "eslint src __tests__ && npm run type-check", | |||
There was a problem hiding this comment.
I think this with & only will run both commands in parallel. Is there a reason to make this sequential?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.