Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable image capture and download of graph #817

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

seve
Copy link
Contributor

@seve seve commented Mar 8, 2024

#393

Adds image downloading button

Feature flag: ?dl=true

Also adds some QOL's for local dev and testing

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.57%. Comparing base (df7d42d) to head (25cd8ac).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #817   +/-   ##
=======================================
  Coverage   76.57%   76.57%           
=======================================
  Files          88       88           
  Lines        6994     6994           
=======================================
  Hits         5356     5356           
  Misses       1638     1638           
Flag Coverage Δ
frontend 76.57% <ø> (ø)
javascript 76.57% <ø> (ø)
unitTest 76.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seve seve enabled auto-merge (squash) March 8, 2024 22:16
Copy link
Contributor

@kaloster kaloster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! 🚀

More of a product thing but maybe we should add some branding to the downloaded image

spatial_emb

@seve seve merged commit c00d3ab into main Mar 8, 2024
6 of 7 checks passed
@seve seve deleted the seve/download-image branch March 8, 2024 22:28
@seve
Copy link
Contributor Author

seve commented Mar 8, 2024

More of a product thing but maybe we should add some branding to the downloaded image

Oh god please no

@seve seve self-assigned this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants