-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add geneset initialization #803
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
==========================================
- Coverage 77.74% 77.47% -0.27%
==========================================
Files 88 88
Lines 6802 6856 +54
==========================================
+ Hits 5288 5312 +24
- Misses 1514 1544 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple items for discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks great! Thanks for all the code comments to provide the context, Alec 🥇 ! Just some nits otherwise LGTM!
Genesets are stored as a JSON blob in the obs tiledb metadata under key "genesets". The new endpoint added to the server simply forwards this blob to the client.
The client added back geneset initialization from CELLxGENE Annotate.
Each cell type present in a CellGuide CXG has its own marker gene set from CellGuide.
Also added some QOL improvements to the categorical data: