-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Story 4: Export PNG #728
Comments
@atarashansky @niknak33 maybe we should align on what's included in the downloaded image - I suppose it's just whatever is currently rendered on the canvas + a legend, like what Loupe has? |
Hey team! Please add your planning poker estimate with Zenhub @kaloster @seve |
This seems totally reasonable to me! I'd suggest adding a scale bar if possible. Also, this is a total nit, but let's align the legend in the top left and add a few pixels of padding if possible. |
#742 spike blocks this ticket, because we'll use that spike ticket to port over Excellxgene's code to export image |
@sidneymbell Oh great idea! I'll add the requirement to move the legend to the top left 👍 I like the scale bar as well! To do it properly, should we extract that feature out as a standalone ticket, so we can add the scale bar both in Explorer and the downloaded image? (I see that Loupe Browser has the scale bar in their app but surprisingly not in their downloaded image, so this is our time to do better than them! Bwahaha) Another reason to extract scale bar out as a standalone ticket is that we've never implemented a scale bar before, so we'd need to do some research to make sure our implementation works and can be validated 😆! Scale Bar ticket: https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/gh/chanzuckerberg/single-cell-explorer/749. We can prioritize this after the MVP to see when we want to add this feature! |
Ah okay, I just played with the Loupe Browser a bit more. The exported image dimension actually corresponds to your Loupe Browser app window dimension, so it's a YSWYG experience To simplify the feature for Explorer, it feels like maybe we can just stick with exporting hardcoded image dimensions to start with and iterate on what the users actually need later? |
@seve : Okay just chatted with @niknak33 on the exported PNG file dimension, we should just use the minimal "hi-res" image dimensions required by the schema (2000x2000, I believe?) as the hard coded image dimension, so even if the "hi-res" image dimensions provided by the user is larger than 2000x2000, the exported PNG file would still look good? CC: @sidneymbell to confirm the 2000x2000 min "hi-res" requirement is correct 🙏 Thank you! |
@seve said "there’c currently no legend, I’m not sure how we want to show legends for categorical color by" CC: @niknak33 @sidneymbell to see if you can help clarify the requirement for legend Thanks! |
@seve I think we're missing e2e test for this? Thanks! |
I spent some time looking through chromatic's API docs to see if it can diff downloaded images, but couldn't find any resources that made it seem like it could. Any advice on testing? Also I left this issue open because of the open question to @niknak33 |
Wonder if we could download the image and open it in a browser tab for Chromatic to screenshot? |
sync'd offline - will keep this ticket open until the e2e tests are covered! |
User Story 4:
As a data consumer, I want to export visualizations or specific data subsets from the spatial data, so that I can use them in presentations, publications, or further analysis with other tools.
DoD:
NOTES:
Excellxgene example - we can probably just have a screenshot button instead of a dropdown, since we don't have other download options
The text was updated successfully, but these errors were encountered: